This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] ios: copy all meta data from the original image.#1617
Merged
cyanglaz merged 4 commits intoflutter:masterfrom May 22, 2019
Merged
[image_picker] ios: copy all meta data from the original image.#1617cyanglaz merged 4 commits intoflutter:masterfrom
cyanglaz merged 4 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
@ko2ic Do you mind to take a look at this as well? |
collinjackson
approved these changes
May 21, 2019
Contributor
|
@cyanglaz I was able to confirm on real devices that the correct value was obtained also for GPS and so on. |
Contributor
Author
|
@ko2ic Great! Thanks. will merge this in today. The only problem left now is gif and we might have to come up a way to either support scaling gifs or fail properly if the scaling parameters are passed. |
This was referenced May 22, 2019
13 tasks
|
iOS still rotates the picked image 90 degrees? Am I supposed to see the change using the latest Flutter SDK? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up #1586. Copying over all the metadata, including GPS, orientation and more.
Note that because orientation is copied, we have to revert the orientation that iOS has done on the picked image to make the image show up in a correct way on the phone.
Related Issues
flutter/flutter#31751
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?