Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] ios: copy all meta data from the original image.#1617

Merged
cyanglaz merged 4 commits intoflutter:masterfrom
cyanglaz:image_picker_all_metadata
May 22, 2019
Merged

[image_picker] ios: copy all meta data from the original image.#1617
cyanglaz merged 4 commits intoflutter:masterfrom
cyanglaz:image_picker_all_metadata

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented May 20, 2019

Description

Follow up #1586. Copying over all the metadata, including GPS, orientation and more.

Note that because orientation is copied, we have to revert the orientation that iOS has done on the picked image to make the image show up in a correct way on the phone.

Related Issues

flutter/flutter#31751

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz cyanglaz self-assigned this May 20, 2019
@cyanglaz
Copy link
Contributor Author

@ko2ic Do you mind to take a look at this as well?

@ko2ic
Copy link
Contributor

ko2ic commented May 22, 2019

@cyanglaz I was able to confirm on real devices that the correct value was obtained also for GPS and so on.
Thank you very much for driving this problem and I could learn a lot.

@cyanglaz
Copy link
Contributor Author

@ko2ic Great! Thanks. will merge this in today. The only problem left now is gif and we might have to come up a way to either support scaling gifs or fail properly if the scaling parameters are passed.

@mikron123
Copy link

iOS still rotates the picked image 90 degrees? Am I supposed to see the change using the latest Flutter SDK?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants