Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Return image picker method call results on the platform thread#1585

Merged
cyanglaz merged 1 commit intoflutter:masterfrom
jason-simmons:bug_32315
May 9, 2019
Merged

Return image picker method call results on the platform thread#1585
cyanglaz merged 1 commit intoflutter:masterfrom
jason-simmons:bug_32315

Conversation

@jason-simmons
Copy link
Member

The MediaScanConnection.scanFile callback is invoked on a background thread.
However, MethodChannel results must be provided on the platform thread.

Fixes flutter/flutter#32315

Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@cyanglaz
Copy link
Contributor

cyanglaz commented May 9, 2019

Actually, we also need to update the CHANGELOG and pubspec.yaml

The MediaScanConnection.scanFile callback is invoked on a background thread.
However, MethodChannel results must be provided on the platform thread.

Fixes flutter/flutter#32315
@jason-simmons
Copy link
Member Author

Updated version to 0.6.0+3 and added a release note

@cyanglaz
Copy link
Contributor

cyanglaz commented May 9, 2019

@jason-simmons Looks good! Thank you for doing this.

@cyanglaz cyanglaz merged commit c153033 into flutter:master May 9, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

image_picker with Flutter 1.5.9

3 participants