Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix break in firebase_analytics CocoaPod #1581

Merged
collinjackson merged 3 commits into from
May 7, 2019
Merged

Fix break in firebase_analytics CocoaPod #1581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c11f3a5
Fix break in firebase_analytics CocoaPod
collinjackson May 7, 2019
fedacfb
Code review feedback
collinjackson May 7, 2019
db331b5
CHANGELOG
collinjackson May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/firebase_analytics/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 3.0.1

* Switch to using the `FIRAnalytics` version of `setAnalyticsCollectionEnabled` for
compatibility with Firebase Analytics iOS CocoaPod version 6.0.
* Update podspec to ensure availability of `setAnalyticsCollectionEnabled`.

## 3.0.0

* Update Android dependencies to latest.
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_analytics/ios/Classes/FirebaseAnalyticsPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
result(nil);
} else if ([@"setAnalyticsCollectionEnabled" isEqualToString:call.method]) {
NSNumber *enabled = [NSNumber numberWithBool:call.arguments];
[[FIRAnalyticsConfiguration sharedInstance] setAnalyticsCollectionEnabled:[enabled boolValue]];
[FIRAnalytics setAnalyticsCollectionEnabled:[enabled boolValue]];
result(nil);
} else if ([@"resetAnalyticsData" isEqualToString:call.method]) {
[FIRAnalytics resetAnalyticsData];
Expand Down
1 change: 1 addition & 0 deletions packages/firebase_analytics/ios/firebase_analytics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ Firebase Analytics plugin for Flutter.
s.ios.deployment_target = '8.0'
s.dependency 'Flutter'
s.dependency 'Firebase/Core'
s.dependency 'Firebase/Analytics', '~> 6.0'
s.static_framework = true
end
2 changes: 1 addition & 1 deletion packages/firebase_analytics/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for Google Analytics for Firebase, an app measuremen
solution that provides insight on app usage and user engagement on Android and iOS.
author: Flutter Team <flutter-dev@googlegroups.com>
homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_analytics
version: 3.0.0
version: 3.0.1

flutter:
plugin:
Expand Down