This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_crashlytics] Migrate FlutterErrorDetails#1564
Merged
mklim merged 2 commits intoflutter:masterfrom May 3, 2019
mklim:dx_nodes
Merged
[firebase_crashlytics] Migrate FlutterErrorDetails#1564mklim merged 2 commits intoflutter:masterfrom mklim:dx_nodes
mklim merged 2 commits intoflutter:masterfrom
mklim:dx_nodes
Conversation
Update our handling of the struct to work on both flutter stable and master. Tested on both master and stable. The plugin itself works on both, but our unit tests now only run on master.
Contributor
Author
|
This should also fix CI. |
jacob314
reviewed
May 3, 2019
packages/firebase_crashlytics/test/firebase_crashlytics_test.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
May 3, 2019
| stack: StackTrace.current, | ||
| library: 'foo library', | ||
| context: 'foo context', | ||
| informationCollector: (StringBuffer information) { |
There was a problem hiding this comment.
strange the test still passes with these lines removed.
jacob314
approved these changes
May 3, 2019
kroikie
approved these changes
May 3, 2019
packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart
Outdated
Show resolved
Hide resolved
packages/firebase_crashlytics/lib/src/firebase_crashlytics.dart
Outdated
Show resolved
Hide resolved
collinjackson
approved these changes
May 3, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Update our handling of the struct to work on both flutter stable and master. The plugin itself works on both, but our unit tests now only run on master.
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
* implement android v2 embedding for firebase_messaging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update our handling of the struct to work on both flutter stable and
master. Tested on both master and stable. The plugin itself works on
both, but our unit tests now only run on master.
Related Issues
flutter/flutter#31962
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?