Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Update README. Increment version.#1561

Merged
mklim merged 4 commits intoflutter:masterfrom
mklim:iap_readme_changelog
May 2, 2019
Merged

[in_app_purchase] Update README. Increment version.#1561
mklim merged 4 commits intoflutter:masterfrom
mklim:iap_readme_changelog

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented May 2, 2019 •
edited
Loading

Description

Update README for initial release. Increment version.

Related Issues

flutter/flutter#9591

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@mklim mklim requested review from amirh and cyanglaz May 2, 2019 02:36
@amirh
Copy link
Contributor

amirh commented May 2, 2019

yay

amirh
amirh approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please update the PR description template

cyanglaz
cyanglaz reviewed May 2, 2019
View reviewed changes
cyanglaz
cyanglaz approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklim mklim merged commit 20449bf into flutter:master May 2, 2019
@mklim mklim deleted the iap_readme_changelog branch May 2, 2019 20:23
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@feinstein @collinjackson
[firebase_crashlytics] No need for async as there's no await (flutter…
137a354 
…#1561)

* No need for async as there's no await

* Update CHANGELOG.md

* Update pubspec.yaml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@amirh amirh amirh approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mklim @amirh @cyanglaz @googlebot