Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[in_app_purchase] Remove extraneous download logic#1560

Merged
mklim merged 1 commit intoflutter:masterfrom
mklim:iap_remove_download
May 1, 2019
Merged

[in_app_purchase] Remove extraneous download logic#1560
mklim merged 1 commit intoflutter:masterfrom
mklim:iap_remove_download

Conversation

@mklim
Copy link
Contributor

@mklim mklim commented May 1, 2019

Description

Not supporting downloads right now, but there's some dangling unit tests
and members that still reference them. Remove them and regenerate the
mapping classes.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

Not supporting downloads right now, but there's some dangling unit tests
and members that still reference them. Remove them and regenerate the
mapping classes.
@mklim mklim requested a review from cyanglaz May 1, 2019 21:59
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download

@mklim mklim merged commit 5ba657d into flutter:master May 1, 2019
@mklim mklim deleted the iap_remove_download branch May 1, 2019 22:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants