Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[Firebase messaging] iOS direct data messages#1318

Merged
collinjackson merged 4 commits intoflutter:masterfrom
jaumard:feature/iosFirebaseMessagingDataMessages
May 10, 2019
Merged

[Firebase messaging] iOS direct data messages#1318
collinjackson merged 4 commits intoflutter:masterfrom
jaumard:feature/iosFirebaseMessagingDataMessages

Conversation

@jaumard
Copy link
Contributor

@jaumard jaumard commented Mar 6, 2019

fixes flutter/flutter#25650
fixes flutter/flutter#29714

To use this right now do:

firebase_messaging: #^4.0.0+1
    git:
      url: git://github.com/jaumard/plugins
      ref: feature/iosFirebaseMessagingDataMessages
      path: packages/firebase_messaging

@jaumard jaumard force-pushed the feature/iosFirebaseMessagingDataMessages branch 2 times, most recently from cce80a8 to bfeee00 Compare March 7, 2019 14:41
@amervelic
Copy link

amervelic commented Mar 9, 2019

Please fix custom notification sound on android oreo+ ( notification channel)

@kroikie
Copy link
Contributor

kroikie commented Apr 15, 2019

@jaumard Thanks for the PR! Could you please make this an optional operation on the Dart side?

If a developer is not using direct messages then there is no need to have this channel open. So let's follow the native SDK and give the option to the developer to enable the channel or not.

@jaumard
Copy link
Contributor Author

jaumard commented Apr 16, 2019

@kroikie yes I can, but it will change the cross platform behavior.
Because on Android you get out of the box push notification and direct messages, shouldn't be the same on iOS ? that's why I didn't hide it behind a flag.

Let me know what you think !

@collinjackson
Copy link
Contributor

Thanks, this PR looks great!

Perhaps we should call shouldEstablishDirectChannel in response to configure since at that point the onMessage method will actually do something.

Don't forget to update pubspec.yaml

@jaumard jaumard force-pushed the feature/iosFirebaseMessagingDataMessages branch from bfeee00 to f33e109 Compare May 9, 2019 08:30
@jaumard jaumard force-pushed the feature/iosFirebaseMessagingDataMessages branch from f33e109 to 5613282 Compare May 9, 2019 08:33
@jaumard
Copy link
Contributor Author

jaumard commented May 9, 2019

Hey @collinjackson I've rebase and update pubspec and changelog, let me know if it's all good :)

@jaumard
Copy link
Contributor Author

jaumard commented May 9, 2019

I also moved the shouldEstablishDirectChannel in configure response

@collinjackson collinjackson merged commit 5f50d6d into flutter:master May 10, 2019
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_messaging] data message not triggering onMessage on foreground Firebase cloud messaging notification object required on iOS

6 participants