[Firebase messaging] iOS direct data messages#1318
[Firebase messaging] iOS direct data messages#1318collinjackson merged 4 commits intoflutter:masterfrom
Conversation
cce80a8 to
bfeee00
Compare
|
Please fix custom notification sound on android oreo+ ( notification channel) |
|
@jaumard Thanks for the PR! Could you please make this an optional operation on the Dart side? If a developer is not using direct messages then there is no need to have this channel open. So let's follow the native SDK and give the option to the developer to enable the channel or not. |
|
@kroikie yes I can, but it will change the cross platform behavior. Let me know what you think ! |
|
Thanks, this PR looks great! Perhaps we should call Don't forget to update pubspec.yaml |
bfeee00 to
f33e109
Compare
f33e109 to
5613282
Compare
|
Hey @collinjackson I've rebase and update pubspec and changelog, let me know if it's all good :) |
|
I also moved the shouldEstablishDirectChannel in configure response |
* ios direct data messages to fix flutter/flutter#25650
fixes flutter/flutter#25650
fixes flutter/flutter#29714
To use this right now do: