This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] delete original file if scaled#1288
Merged
cyanglaz merged 4 commits intoflutter:masterfrom Mar 11, 2019
Merged
Conversation
cyanglaz
suggested changes
Mar 11, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
Thanks for the PR.
Please add the versioning update following the rules here https://www.dartlang.org/tools/pub/versioning#semantic-versions
...s/image_picker/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerDelegate.java
Show resolved
Hide resolved
cyanglaz
suggested changes
Mar 11, 2019
packages/image_picker/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 0.5.0+4 | |||
|
|
|||
| * Deleting original image if image was scaled | |||
Contributor
There was a problem hiding this comment.
NIT:
Suggested change
| * Deleting original image if image was scaled | |
| * Delete the original image if it was scaled. |
cyanglaz
approved these changes
Mar 11, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
LGTM!
Thank you so much again for the contribution.
There seems to be some conflicts of the PR. If you'd like to resolve the conflicts, I can merge it after.
ivk1800
force-pushed
the
delete_original_file_after_scaling
branch
from
88700eb to
6fdf2fc
Compare
Contributor
Author
|
@cyanglaz done! I forgot rebase my master to upstream |
This was referenced Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed flutter/flutter#23500