This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Fix cloud firestore platform error 0#1267
Closed
tomalabaster wants to merge 3 commits intoflutter:masterfrom
tomalabaster:fix_cloud_firestore_platform_error_0
Closed
Fix cloud firestore platform error 0#1267tomalabaster wants to merge 3 commits intoflutter:masterfrom tomalabaster:fix_cloud_firestore_platform_error_0
tomalabaster wants to merge 3 commits intoflutter:masterfrom
tomalabaster:fix_cloud_firestore_platform_error_0
Conversation
Contributor
|
Thank you for providing the fix. The issue has been fixed with #1274. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this PR has caused
cloud_firestoreto throw PlatformExceptions incorrectly. ThegetFlutterErrormethod never returnsnullas if theerrorargument isnull, the string formatting puts 0 in theerrorWithCodeparameter causing aFlutterErrorto always return.