This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[firebase_ml_vision] Fix crash when scanning URL QR-code on iOS#1223
Merged
bparrishMines merged 3 commits intoflutter:masterfrom Mar 1, 2019
gi097:patch-1
Merged
[firebase_ml_vision] Fix crash when scanning URL QR-code on iOS#1223bparrishMines merged 3 commits intoflutter:masterfrom gi097:patch-1
bparrishMines merged 3 commits intoflutter:masterfrom
gi097:patch-1
Conversation
- `NSDictionary` does not accept direct `null pointers`, use `NSNull` instead - Other types might needs this check as well
gi097
changed the title
bparrishMines
changed the title
bparrishMines
added
bugfix
submit queue
bparrishMines
approved these changes
Mar 1, 2019
Contributor
bparrishMines
left a comment
bparrishMines
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the contribution! I'll merge once tests pass.
romaluca
pushed a commit
to romaluca/plugins
that referenced
this pull request
Mar 6, 2019
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NSDictionarydoes not accept directnull pointers, useNSNullinstead