[go_router] Fix routing to treat URLs with different cases (e.g., /Home vs /home) as distinct routes.#9426
Merged
auto-submit[bot] merged 6 commits intoflutter:mainfrom Jun 24, 2025
Conversation
Contributor
Author
|
There is now a failing test for |
Contributor
|
you will have to disable the test first and do a 3 phase transition, for disable and enabling the test I think you can use noversion and changlog exception |
11 tasks
Contributor
Author
|
Fair enough! I've created the PR to skip the test in |
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 23, 2025
Part of flutter/flutter#169809 Prepare for #9426, this skips a test that needs to migrated with the new version of `go_router`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
ValentinVignal
added
the
autosubmit
11 tasks
Contributor
Author
|
PR to unskipt the test #9482 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 24, 2025
….g., `/Home` vs `/home`) as distinct routes. (flutter/packages#9426)
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 24, 2025
flutter/packages@02770da...d9d3191 2025-06-24 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs (flutter/packages#9267) 2025-06-24 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix routing to treat URLs with different cases (e.g., `/Home` vs `/home`) as distinct routes. (flutter/packages#9426) 2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs - Platform Implementations (flutter/packages#9479) 2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from 0ab008a to d733bea (16 revisions) (flutter/packages#9478) 2025-06-23 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Skip case sensitive test (flutter/packages#9444) 2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs - Platform Interface (flutter/packages#9454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
Part of flutter/flutter#169809 Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes
pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…ome` vs `/home`) as distinct routes. (flutter#9426) Fixes flutter/flutter#169809 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 10, 2025
…9482) Part of - flutter/flutter#169809 Follow-up of - #9426 - #9444 Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Jul 21, 2025
flutter/packages@02770da...d9d3191 2025-06-24 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs (flutter/packages#9267) 2025-06-24 32538273+ValentinVignal@users.noreply.github.com [go_router] Fix routing to treat URLs with different cases (e.g., `/Home` vs `/home`) as distinct routes. (flutter/packages#9426) 2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs - Platform Implementations (flutter/packages#9479) 2025-06-23 engine-flutter-autoroll@skia.org Roll Flutter from 0ab008a to d733bea (16 revisions) (flutter/packages#9478) 2025-06-23 32538273+ValentinVignal@users.noreply.github.com [go_router_builder] Skip case sensitive test (flutter/packages#9444) 2025-06-23 stuartmorgan@google.com [google_sign_in] Redesign API for current identity SDKs - Platform Interface (flutter/packages#9454) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
Part of flutter/flutter#169809 Prepare for flutter#9426, this skips a test that needs to migrated with the new version of `go_router`. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…ome` vs `/home`) as distinct routes. (flutter#9426) Fixes flutter/flutter#169809 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
vashworth
pushed a commit
to vashworth/packages
that referenced
this pull request
Jul 30, 2025
…lutter#9482) Part of - flutter/flutter#169809 Follow-up of - flutter#9426 - flutter#9444 Unskips and migrates the test about case sensitivity to the new version of `go_router` 15.2.4. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#169809
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3