[video_player] Add html 5 video poster support (thumbnail) as a VideoPlayerWebOptions#8940
Conversation
713c652 to
d529939
Compare
d529939 to
b43bf65
Compare
2b124fe to
71ea426
Compare
|
Where is the combination PR for initial review that this was split from (per the documented process)? |
c3d02e8 to
eb0d4b7
Compare
|
Sorry for the mess, I messed up while trying to rebase, it is clean now |
|
It looks like this never got a test at the web implementation package level, which was missed during review. is an example of a test similar to what we should have for this. |
…emoving null assignment in VideoPlayerWebOptions
I added tests, they are AI generated but looks good to me and they pass of course. I hope that will do it |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
It's fine to use AI as part of your development process, but you are responsible for ensuring the quality of the code you submit for review regardless of how it was initially created.
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/example/integration_test/video_player_test.dart
Outdated
Show resolved
Hide resolved
packages/video_player/video_player_web/lib/src/video_player.dart
Outdated
Show resolved
Hide resolved
…poster attribute handling
This PR adds support for the
posterattribute on web by introducing aposterfield inVideoPlayerWebOptions. It allows setting a thumbnail image for videos using the native HTML5posterproperty, improving the out-of-the-box web experience.Fixes flutter/flutter#166232
Pre-Review Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3