[two_dimensional_scrollables] Fix TreeView bug when animation duration is zero#7475
Merged
auto-submit[bot] merged 8 commits intoflutter:mainfrom Sep 11, 2024
Conversation
Piinks
changed the title
Piinks
added
the
p: two_dimensional_scrollables
Piinks
reviewed
Aug 22, 2024
packages/two_dimensional_scrollables/test/tree_view/tree_test.dart
Outdated
Show resolved
Hide resolved
Piinks
reviewed
Aug 28, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
We should have an issue specific to this. Can you check https://github.com/flutter/flutter/issues?q=is%3Aopen+is%3Aissue+label%3A%22p%3A+two_dimensional_scrollables%22 and see if one exists? The other issue is for the 1D version in the framework.
Piinks
approved these changes
Sep 11, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
QuncCccccc
reviewed
Sep 11, 2024
packages/two_dimensional_scrollables/lib/src/tree_view/tree.dart
Outdated
Show resolved
Hide resolved
QuncCccccc
approved these changes
Sep 11, 2024
Contributor
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution:)
QuncCccccc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 12, 2024
flutter/packages@4c18648...91caa7a 2024-09-11 50643541+Mairramer@users.noreply.github.com [two_dimensional_scrollables] Fix TreeView bug when animation duration is zero (flutter/packages#7475) 2024-09-11 109111084+yaakovschectman@users.noreply.github.com [google_maps_flutter_platform_interface] Fix typo in CameraUpdateNewLatLngBounds.toJson (flutter/packages#7626) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153889 an issue where nodes were being removed incorrectly when using
AnimationStyle.noAnimationor the animation duration was zero seconds, which previously caused the erratic behavior due to hidden state updates. Similar to flutter/flutter#153890.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.