[in_app_purchase] Add api to expose country code by reidbaker · Pull Request #6540 · flutter/packages

reidbaker · 2024-04-15T17:03:40Z

Add changelog and version bump
dependency override from package tool

Fixes flutter/flutter/issues/141627

Pre-launch Checklist

LouiseHsu

ios side lgtm! thanks for adding the ios implementation too!

gmackall

Android LGTM! Just some nitpicky docs comments

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart

packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md

...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

…ANGELOG.md Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

…b/src/in_app_purchase_platform.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

stuartmorgan-g

Minor comments, but this looks good to split out the first PR (with just the platform interface part).

stuartmorgan-g · 2024-04-16T18:16:11Z

packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart

+  ///
+  ///
+  Future<void> countryCode() =>
+      throw UnimplementedError('countryCode() has not been implemented.');


Shouldn't this be calling the new platform interface method?

And you'll want to add Dart unit tests at this layer that it is in fact calling through.

Done! Thanks for the out of band explanation of this packages value.

stuartmorgan-g · 2024-04-16T18:17:36Z

packages/in_app_purchase/in_app_purchase/pubspec.yaml

+version: 3.2.0

 environment:
  sdk: ^3.1.0


FYI these values will need to be updated to match i_a_p_storekit's lower limits when you do the final app-facing PR, otherwise pub get will fail.

packages/in_app_purchase/in_app_purchase_platform_interface/CHANGELOG.md

...ges/in_app_purchase/in_app_purchase_platform_interface/lib/src/in_app_purchase_platform.dart

… have a test in addition to in_app_purchase_interface

Original pr #6540 Related to flutter/flutter#141627

…kit (#6556) Part of flutter/flutter/issues/141627 reviewed pr #6540

reidbaker · 2024-04-17T19:47:59Z

Assuming the tests pass this pr is ready to land.

LouiseHsu

LGTM!

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md

…kages#6540)

flutter/packages@d39830e...0e3809d 2024-04-18 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/packages#6562) 2024-04-18 stuartmorgan@google.com [ci] Add Linux desktop support to Linux custom_package_tests (flutter/packages#6551) 2024-04-17 katelovett@google.com [two_dimensional_scrollables] Refactor Spans for common use (flutter/packages#6550) 2024-04-17 reidbaker@google.com [in_app_purchase] Add api to expose country code (flutter/packages#6540) 2024-04-17 stuartmorgan@google.com [camera] Initial iOS Pigeon conversion (flutter/packages#6553) 2024-04-17 reidbaker@google.com [in_app_purchase] Add countryCode implementation to android and storekit (flutter/packages#6556) 2024-04-17 magder@google.com [google_sign_in_ios] Upgrade GoogleSignIn iOS SDK to 7.1 (flutter/packages#6404) 2024-04-17 reidbaker@google.com [in_app_purchase_platform_interface] Adds countryCode API (flutter/packages#6548) 2024-04-17 stuartmorgan@google.com [google_maps_flutter] Update app-facing package iOS requirements (flutter/packages#6552) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Original pr flutter#6540 Related to flutter/flutter#141627

…kit (flutter#6556) Part of flutter/flutter/issues/141627 reviewed pr flutter#6540

- **Add changelog and version bump** - **dependency override from package tool** Fixes flutter/flutter/issues/141627

reidbaker added 2 commits April 15, 2024 10:51

Add changelog and version bump

642f5d6

dependency override from package tool

ab226a4

github-actions bot added p: in_app_purchase platform-android platform-ios platform-macos labels Apr 15, 2024

reidbaker requested review from LouiseHsu and stuartmorgan-g April 15, 2024 17:04

reidbaker added 5 commits April 15, 2024 13:06

Remove changelog

c864572

use instance variable

f25d4a1

Add tests for new platfrom apis

2b1b295

Use const over final

78ed2c6

Format

fa4630e

reidbaker marked this pull request as ready for review April 15, 2024 19:06

reidbaker requested review from bparrishMines and gmackall as code owners April 15, 2024 19:06

LouiseHsu approved these changes Apr 15, 2024

View reviewed changes

gmackall approved these changes Apr 16, 2024

View reviewed changes

reidbaker and others added 3 commits April 16, 2024 14:10

Update packages/in_app_purchase/in_app_purchase/lib/in_app_purchase.dart

111daeb

Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

Update packages/in_app_purchase/in_app_purchase_platform_interface/CH…

24c2e26

…ANGELOG.md Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

Update packages/in_app_purchase/in_app_purchase_platform_interface/li…

4ba0db9

…b/src/in_app_purchase_platform.dart Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>

stuartmorgan-g reviewed Apr 16, 2024

View reviewed changes

Add default implementation, update in_app_purchase/in_app_purchase to…

912ab08

… have a test in addition to in_app_purchase_interface

reidbaker mentioned this pull request Apr 16, 2024

[in_app_purchase_platform_interface] Adds countryCode API #6548

Merged

11 tasks

auto-submit bot pushed a commit that referenced this pull request Apr 17, 2024

[in_app_purchase_platform_interface] Adds countryCode API (#6548)

0dd8de2

Original pr #6540 Related to flutter/flutter#141627

Merge branch 'main' into i141627-country-code-api-top-line

478eb63

reidbaker mentioned this pull request Apr 17, 2024

[in_app_purchase] Add countryCode implementation to android and storekit #6556

Merged

11 tasks

auto-submit bot pushed a commit that referenced this pull request Apr 17, 2024

[in_app_purchase] Add countryCode implementation to android and store…

87ae14f

…kit (#6556) Part of flutter/flutter/issues/141627 reviewed pr #6540

reidbaker added 2 commits April 17, 2024 15:34

Merge branch 'main' into i141627-country-code-api-top-line

782c0d0

Update version codes

008d9f6

github-actions bot removed platform-ios platform-macos labels Apr 17, 2024

reidbaker requested review from LouiseHsu, gmackall and stuartmorgan-g April 17, 2024 19:47

LouiseHsu approved these changes Apr 17, 2024

View reviewed changes

formatting

7f17bbd

reidbaker added the override: no versioning needed Override the check requiring version bumps for most changes label Apr 17, 2024

stuartmorgan-g reviewed Apr 17, 2024

View reviewed changes

packages/in_app_purchase/in_app_purchase_android/CHANGELOG.md Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

stuartmorgan-g approved these changes Apr 17, 2024

View reviewed changes

Leave android alone

750131c

reidbaker removed the override: no versioning needed Override the check requiring version bumps for most changes label Apr 17, 2024

github-actions bot removed the platform-android label Apr 17, 2024

reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024

auto-submit bot merged commit 3f4c0f5 into flutter:main Apr 17, 2024

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Roll Packages from d39830e40c07 to 0e3809d995b6 (9 revisions) flutter/flutter#146992

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 18, 2024

3f4c0f5 [in_app_purchase] Add api to expose country code (flutter/pac…

ab879de

…kages#6540)

vmeretin mentioned this pull request Apr 19, 2024

[in_app_purchase] Fix country code API #6572

Closed

11 tasks

reidbaker deleted the i141627-country-code-api-top-line branch April 19, 2024 15:28

darshankawar mentioned this pull request Apr 23, 2024

getCountryCode methods are not implementing countryCode platform interface method flutter/flutter#147230

Closed

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024

[in_app_purchase_platform_interface] Adds countryCode API (flutter#6548)

0dfcfbc

Original pr flutter#6540 Related to flutter/flutter#141627

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024

[in_app_purchase] Add countryCode implementation to android and store…

d817df4

…kit (flutter#6556) Part of flutter/flutter/issues/141627 reviewed pr flutter#6540

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024

[in_app_purchase] Add api to expose country code (flutter#6540)

8636ace

- **Add changelog and version bump** - **dependency override from package tool** Fixes flutter/flutter/issues/141627

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[in_app_purchase] Add api to expose country code#6540

[in_app_purchase] Add api to expose country code#6540
auto-submit[bot] merged 20 commits intoflutter:mainfrom
reidbaker:i141627-country-code-api-top-line

reidbaker commented Apr 15, 2024 •

edited

Loading

Uh oh!

LouiseHsu left a comment

Uh oh!

gmackall left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Apr 16, 2024

Uh oh!

stuartmorgan-g Apr 16, 2024

Uh oh!

reidbaker Apr 16, 2024

Uh oh!

stuartmorgan-g Apr 16, 2024

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 17, 2024

Uh oh!

LouiseHsu left a comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

reidbaker commented Apr 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

LouiseHsu left a comment

Choose a reason for hiding this comment

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 16, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 17, 2024

Uh oh!

LouiseHsu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

reidbaker commented Apr 15, 2024 •

edited

Loading