Conversation
Since a large number of CI checks are failing, I'm assuming this is a work in progress, and marking it as a Draft accordingly, Please mark it as ready for review once it's passing. |
…om/jemishavasoya/packages into css_colors-add-example-app-#136217
…om/jemishavasoya/packages into css_colors-add-example-app-#136217
The referenced issue is about a completely different package. What's the goal of adding this example app? It's not clear to me what this is accomplishing that the README doesn't (and/or than a simple example.md wouldn't do). We don't need integration tests, for instance. |
|
@jemishavasoya when you get a chance, can you clarify the goal of adding this example? Converting to a draft in the meantime to remove this from our queue. |
|
(triage): @jemishavasoya Do you still have plans to get back to this PR in the near future to address the feedback given above? |
|
Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks! |
added simple example app for it that demonstrates
[css_color] Add example app #136217
#136217
added Example app
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).