Update annotation and espresso dependencies by reidbaker · Pull Request #3271 · flutter/packages

reidbaker · 2023-02-22T20:56:14Z

Update all of packages to the latest compileSdkVersion
See flutter/issues/121425
Non "apps" have their compileSdkVersion hardcoded since the flutter.compileSdkVersion variable is only for apps.
After this PR all plugins in this repo should be up to date with all example apps updated to use the variable shipped in flutter.

Update Espresso plugin to have multidex support
See flutter/flutter/issues/121423

Take over prs from dependabot
#3245
#3240

flutter-dashboard · 2023-02-22T20:56:18Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

packages/flutter_plugin_android_lifecycle/android/build.gradle

Fix example app to launch with multidex partial work on flutter/flutter/issues/121423

ditman · 2023-02-27T21:44:35Z

There's quite a few packages that have an updated CHANGELOG.md, where nothing else changed in them (for example look at: google_maps_flutter_ios, google_maps_flutter_platform_interface, google_maps_flutter_web, camera_avfoundation...)

I think the tool let you down here and updated a bunch more that what it needed to. Reverting those files should make this PR quite smaller?

stuartmorgan-g · 2023-02-27T23:32:18Z

I think the tool let you down here and updated a bunch more that what it needed to.

It's really easy to have the wrong base revision; I still need to change the defaults to make it less of a foot-gun.

…gradle update

reidbaker · 2023-02-28T16:03:12Z

Well this is embarrassing. I am sorry I should have caught this before review. 60 reverted files now updated.

…023-02-22

ditman

Still a few files that can be removed I think, and a small comment about the commit message where the change is compileSdkVersion flutter.compileSdkVersion.

Thanks for this cleanup!

packages/extension_google_sign_in_as_googleapis_auth/example/android/app/build.gradle

packages/extension_google_sign_in_as_googleapis_auth/CHANGELOG.md

ditman · 2023-03-01T01:55:54Z

packages/google_sign_in/google_sign_in_ios/CHANGELOG.md

@@ -1,3 +1,7 @@
+## NEXT
+
+* Update compileSdkVersion to 33.


packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md

packages/google_sign_in/google_sign_in_web/CHANGELOG.md

packages/image_picker/image_picker_for_web/CHANGELOG.md

packages/image_picker/image_picker_ios/CHANGELOG.md

packages/image_picker/image_picker_platform_interface/CHANGELOG.md

packages/image_picker/image_picker_windows/CHANGELOG.md

…023-02-22

…updated

reidbaker · 2023-03-01T16:51:46Z

@stuartmorgan in commit a6b5256 I remove the change log for packages that only have example app modifications. Can you add the label "override: no versioning needed" If you agree this pr meets the exemption requirements.

stuartmorgan-g · 2023-03-01T17:53:30Z

Can you add the label "override: no versioning needed" If you agree this pr meets the exemption requirements.

Just updating the compile SDK definitely seems like the kind of change where overriding the standard policy is reasonable, since there's no advantage to clients in getting this change to them faster. We do the same when we bump the minimum Flutter SDK version.

(I'll document these on the wiki for the future.)

stuartmorgan-g

LGTM other than the merge issues. Thanks for bearing with all the discussion on what I know was not intended to be this big of a PR :)

stuartmorgan-g · 2023-03-01T17:50:37Z

packages/camera/camera_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## NEXT
+
+* Update compileSdkVersion to 33.


Nit for all files: "Updates" (per https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changelog-style)

stuartmorgan-g · 2023-03-01T18:20:36Z

packages/image_picker/image_picker/CHANGELOG.md

-## 0.8.6+4
-
-* Updates iOS minimum version in README.
-


Looks like this was a bad merge with the recent iOS PR.

stuartmorgan-g · 2023-03-01T18:20:51Z

packages/pigeon/CHANGELOG.md

-
-* [swift] Removes safe casting from decode process.
-* [kotlin] Removes safe casting from decode process.
-


Bad merge with recent PRs.

stuartmorgan-g · 2023-03-01T18:21:08Z

packages/camera/camera/CHANGELOG.md

@@ -1,7 +1,3 @@
-## 0.10.3+2
-
-* Updates iOS minimum version in README.


Bad merge with recent PR.

…inding changelog files

bparrishMines

LGTM

bparrishMines · 2023-03-01T23:10:23Z

@reidbaker Is this ready to merge. It has to be landed on red since it is needed to fix the tree.

Update annotation and espresso dependencies

761baf3

reidbaker requested review from camsim99, gmackall and stuartmorgan-g February 22, 2023 20:56

flutter-dashboard bot added the needs tests label Feb 22, 2023

github-actions bot added p: espresso p: flutter_plugin_android_lifecycle p: google_maps_flutter platform-android labels Feb 22, 2023

Merge branch 'main' into update-dependencies-2023-02-22

223cdb2

stuartmorgan-g reviewed Feb 23, 2023

View reviewed changes

packages/flutter_plugin_android_lifecycle/android/build.gradle Show resolved Hide resolved

reidbaker removed the needs tests label Feb 24, 2023

reidbaker and others added 7 commits February 24, 2023 13:55

Merge branch 'flutter:main' into update-dependencies-2023-02-22

e028fbe

Migrate camera_android to use flutter.compileSdkVersion

1d04d7f

Migrate camera_android_camerax to use flutter.compileSdkVersion

843b10f

Migrate camera_camera to use flutter.compileSdkVersion

078d215

Migrate espresso to use flutter.compileSdkVersion

339206e

Fix example app to launch with multidex partial work on flutter/flutter/issues/121423

Mass replace for flutter.compileSdkVersion on all "apps"

11eccdc

Mass update non app build.gradle files to compileSdkVersion 33

adfe247

reidbaker requested review from Hixie, bparrishMines, chunhtai, ditman, domesticmouse, goderbauer, gspencergoog and tarrinneal as code owners February 24, 2023 21:40

github-actions bot added p: animations p: camera labels Feb 24, 2023

Remove all changelog changes from packages that did not have a build.…

f1bb19e

…gradle update

reidbaker added 3 commits February 28, 2023 11:14

Merge remote-tracking branch 'origin/main' into update-dependencies-2…

27d7b8e

…023-02-22

formatting update

50f8456

Add copyright to multidex application because it fails repro checks

0754cfc

ditman approved these changes Mar 1, 2023

View reviewed changes

reidbaker added 3 commits March 1, 2023 11:07

Remove more unneeded changelog files unrelated to android

1931da2

Merge remote-tracking branch 'origin/main' into update-dependencies-2…

78f1565

…023-02-22

Remove CHANGELOG entries for packages where only the example app was …

a6b5256

…updated

stuartmorgan-g approved these changes Mar 1, 2023

View reviewed changes

reidbaker mentioned this pull request Mar 1, 2023

[image_picker] Updates example app Android compileSdkVersion to 33. #3344

Closed

11 tasks

reidbaker added 2 commits March 1, 2023 15:28

Fix bad merge in changelog files and change update to updates in rema…

677bd6e

…inding changelog files

Fix more update -> updates

e6f1bc8

bparrishMines approved these changes Mar 1, 2023

View reviewed changes

stuartmorgan-g mentioned this pull request Mar 2, 2023

[ci+various] Partially enable javac warning checks #3293

Merged

11 tasks

reidbaker mentioned this pull request Mar 2, 2023

Create migrator for updating compileSdkVersion for developer owned projects flutter/flutter#121824

Open

This was referenced Mar 3, 2023

Roll Flutter from f032a4d64891 to 3494c084481e (68 revisions) #3363

Closed

Roll Flutter from f032a4d64891 to c590086bcc58 (69 revisions) #3366

Merged

reidbaker mentioned this pull request Mar 20, 2023

[Many] i123017 integration annotation documentation #3495

Merged

10 tasks


		* [swift] Removes safe casting from decode process.
		* [kotlin] Removes safe casting from decode process.

		@@ -1,7 +1,3 @@
		## 0.10.3+2

		* Updates iOS minimum version in README.

Conversation

reidbaker commented Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flutter-dashboard bot commented Feb 22, 2023

Uh oh!

Uh oh!

ditman commented Feb 27, 2023

Uh oh!

stuartmorgan-g commented Feb 27, 2023

Uh oh!

reidbaker commented Feb 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ditman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ditman Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

reidbaker Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Mar 1, 2023

Uh oh!

stuartmorgan-g commented Mar 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 1, 2023

Choose a reason for hiding this comment

Uh oh!

bparrishMines left a comment

Choose a reason for hiding this comment

Uh oh!

bparrishMines commented Mar 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

reidbaker commented Feb 22, 2023 •

edited

Loading

reidbaker commented Feb 28, 2023 •

edited

Loading

stuartmorgan-g commented Mar 1, 2023 •

edited

Loading