[pigeon] add non-null type arguments#1225
Closed
gaaclarke wants to merge 6 commits intoflutter:mainfrom
Closed
Conversation
Member
Author
|
Let me look into this a bit tomorrow. I'm think I can use a custom codec to encode Lists with non null values on the java and objc side to throw an exception if it finds a null value. |
Member
Author
|
Because of the null-safe limitation in ObjC and Java this PR has been stalled indefinitely. For example, you can't put nullability tags for types in type arguments to generic containers in ObjC or Java. I haven't found a good path forward and am not sure I recommend attempting it until we support kotlin and swift. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this was only meaningful for the Dart generator. That's why most of the work is in the Dart generator.
fixes flutter/flutter#97848
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.