Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request opts out of icon tree shaking for RFW by adding ignore comments for the non_const_argument_for_const_parameter lint. This is necessary because RFW creates IconData instances with dynamic data, which is incompatible with the new @mustBeConst annotations on IconData parameters. The change is correct in principle, but it seems to be missing an ignore for the matchTextDirection parameter, which is also marked as @mustBeConst.
| icon, | ||
| // ignore: non_const_argument_for_const_parameter | ||
| fontFamily: source.v<String>([...key, 'fontFamily']), | ||
| matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false, |
There was a problem hiding this comment.
It seems you've missed adding an ignore for the matchTextDirection parameter. According to the Flutter PR you linked, matchTextDirection is also annotated with @mustBeConst. Since the value passed here is not a compile-time constant, it will also trigger the non_const_argument_for_const_parameter lint and should be ignored.
Suggested change
| matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false, | |
| // ignore: non_const_argument_for_const_parameter | |
| matchTextDirection: source.v<bool>([...key, 'matchTextDirection']) ?? false, |
Contributor
Author
There was a problem hiding this comment.
mr AI bot, you are talking BS:
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2026
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 11, 2026
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 11, 2026
flutter/packages@ee460d6...ecace66 2026-03-11 srawlins@google.com [pigeon] Produce a helpful error for bad method return type (flutter/packages#11204) 2026-03-11 srawlins@google.com [pigeon] Use hasLength and isEmpty in tests for better failure messages (flutter/packages#11205) 2026-03-11 dacoharkes@google.com [rfw] Opt out of icon tree shaking (flutter/packages#11216) 2026-03-11 srawlins@google.com [pigeon] Tidy imports and "ignore" comments (flutter/packages#11149) 2026-03-11 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump org.jetbrains.kotlin:kotlin-bom from 2.2.21 to 2.3.10 in /packages/pigeon/platform_tests/test_plugin/android (flutter/packages#10984) 2026-03-11 srawlins@google.com [pigeon] Improve casting and nullability-handling in generated code (flutter/packages#11163) 2026-03-10 engine-flutter-autoroll@skia.org Roll Flutter from 2ec61af to 195ae7b (36 revisions) (flutter/packages#11222) 2026-03-10 git@reb0.org [vector_graphics] Respect BoxFit parameter with viewbox (flutter/packages#11012) 2026-03-10 stuartmorgan@google.com Add AI contribution guidelines to PR checklist (flutter/packages#11195) 2026-03-10 zezohassam@gmail.com [video_player] Optimize caption retrieval with binary search in VideoPlayerController (flutter/packages#8347) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dcharkes
added a commit
to flutter/tests
that referenced
this pull request
Mar 16, 2026
dcharkes
added a commit
to flutter/tests
that referenced
this pull request
Mar 16, 2026
Roll in flutter/packages#11216. To make flutter/flutter#181345 go green.
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 24, 2026
2026-03-18 update, no push-back on the breaking changes. Migrations done downstream: * fluttercommunity/font_awesome_flutter#297 * PiotrRogulski/kanji_app@76973c7 * flutter/packages#11216 * FaFre/WebLibre#214 * flutter/devtools#9718 ----------- Applying breaking changes: * #181342 * #181344 See the issue descriptions for the motivation. cc @Piinks It seems we have a non-const use in the Remote Flutter Widgets: https://github.com/flutter/packages/blob/d0c7d1fad77331724882614345137221c77d5758/packages/rfw/lib/src/flutter/argument_decoders.dart#L801-L811 The package itself makes no mention of it not work with the Flutter Icon Tree Shaker. If it's a know issue that the icon tree shaker is not supported with `package:rfw` we can add `// ignore: non_const_argument_for_const_parameter`. (flutter/packages#10858)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are introducing the
@mustBeConstannotation onIconDataparameters that must be const in order for the icon tree shaker to work:IconData's constructor parameters as@mustBeConstflutter#181344IconDatafinaland@mustBeConstflutter#181345RFW does not support tree-shaking.
This PR adds the lint ignores with an explicit comment that the lint ignore is intentional.