Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Android Gradle Plugin version from 8.6.0 to 8.9.1 in .ci/legacy_project/all_packages/android/settings.gradle. My review identifies a potential issue where a corresponding Gradle version update might be necessary to ensure compatibility with the new AGP version, which could otherwise lead to build failures.
stuartmorgan-g
approved these changes
Nov 18, 2025
Collaborator
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, but please update the project change description to match.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 19, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 19, 2025
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
okorohelijah
pushed a commit
to okorohelijah/flutter
that referenced
this pull request
Nov 21, 2025
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
IvoneDjaja
pushed a commit
to IvoneDjaja/flutter
that referenced
this pull request
Nov 22, 2025
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Dec 2, 2025
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
flutter/packages@34746bb...8f72e4b 2025-11-19 victoreronmosele@gmail.com [rfw] Update broken links in rfw's README.md (flutter/packages#9796) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.activity:activity from 1.10.1 to 1.11.0 in /packages/image_picker/image_picker_android/android (flutter/packages#10045) 2025-11-19 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump androidx.core:core from 1.13.1 to 1.17.0 in /packages/url_launcher/url_launcher_android/android (flutter/packages#9855) 2025-11-19 matt.boetger@gmail.com Upgrade AGP to 8.9.1 (flutter/packages#10458) 2025-11-18 stuartmorgan@google.com [pigeon] Update analyzer range to 8-9 (flutter/packages#10466) 2025-11-18 stuartmorgan@google.com [in_app_purchase] Rename Swift Pigeon output file (flutter/packages#10465) 2025-11-18 engine-flutter-autoroll@skia.org Roll Flutter from cc14ef5 to cb7b7df (20 revisions) (flutter/packages#10464) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades AGP to 8.9.1. A few dependabot PRs are stuck because they are failing with similar error messages:
Blocked PRs:
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).