Remove FlutterApplication from app templates.#64742
Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom Sep 17, 2020
Merged
Remove FlutterApplication from app templates.#64742fluttergithubbot merged 1 commit intoflutter:masterfrom
fluttergithubbot merged 1 commit intoflutter:masterfrom
Conversation
Member
|
Reminds me I need to merge flutter/engine#20769 (since this inadvertently hides a problem flutter/engine#20769 fixes) . Let's merge this after our next branch cut next week. |
xster
approved these changes
Sep 4, 2020
Member
xster
left a comment
There was a problem hiding this comment.
This LGTM. flutter/engine#20769 is merged as well.
Please wait until Sept 14th before merging this.
Contributor
|
@xster September 14th of this year, right? :) |
Member
|
Thanks for reminding Jonah! Merge on green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is an inconsistency between the migration guide for pre flutter 1.12 android applications: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects and the current app templates.
According to the guide (for both, Full-Flutter app migration as well as for Add-to-app migration):
This PR removes
FlutterApplicationfromAndroidManifest.xmlto make it consistent with manually upgraded projects.Related Issues
Tests
No tests, as this does not add any functionality.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read [Handling breaking changes].