Skip to content

[DisplayList] Use internal conversion for opacity->alpha#165349

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
flar:dl-paint-opacity-conversion
Mar 18, 2025
Merged

[DisplayList] Use internal conversion for opacity->alpha#165349
auto-submit[bot] merged 1 commit intoflutter:masterfrom
flar:dl-paint-opacity-conversion

Conversation

@flar
Copy link
Contributor

@flar flar commented Mar 17, 2025

Removing an unnecessary dependence on an external library for doing opacity->alpha conversions in DlPaint.

@flar flar marked this pull request as ready for review March 17, 2025 22:15
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Mar 17, 2025
@flar
Copy link
Contributor Author

flar commented Mar 17, 2025 •
edited
Loading

This change could have been combined with other refactors, but since this line of code is used by OpacityLayers, there is a real potential to cause a large number of off-by-1 diffs in goldens.

jonahwilliams
jonahwilliams approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit c5d4edf Mar 18, 2025
170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
6a937f2 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
af7e134 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
c0a3340 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
8ab7b82 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ee38b9d 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
2d5cecf 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
0d30f48 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
bed0039 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
afe57e3 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
e278e88 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
b221c5a 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
413baf4 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
3420040 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
a27b0d2 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
166dcec 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
5e71e96 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
cc057d9 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
c62aa57 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
b3d6cd7 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
233bd4b 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ea22aab 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
5e7ab55 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
da91074 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
5a076cc 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
fd50cf7 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
eb85d18 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
a4a6939 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
1d4cb36 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ee142e1 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
874fe3a 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
80de790 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ee85b5a 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
746717b 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ebe6311 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
7eea5c5 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
ef3866c 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
432ed9d 
…tter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c5d4edf [DisplayList] Use internal conversion for opacity->alpha (flu…
8ec06f2 
…tter/flutter#165349)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@flar @romanejaquez
[DisplayList] Use internal conversion for opacity->alpha (flutter#165349
f2858c6 
)

Removing an unnecessary dependence on an external library for doing
opacity->alpha conversions in DlPaint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@flar @jonahwilliams