[web] robustify safaridriver launch sequence#162919
[web] robustify safaridriver launch sequence#162919auto-submit[bot] merged 4 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
test-exempt: is a test |
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
Improve safaridriver launch sequence as follows: - Fix retry: the previous version would call `_startDriverProcess` recursively from within a listener to the stderr output. But by then the outer `_startDriverProcess` call would have completed its future, so the retry mechanism would kick in while tests are already running. - Wait for `safaridriver` server process to start listening and responding to WebDriver commands (using `/status` as the smoke test). - Smoke-test the driver session by attempting to list all windows (`WebDriver.windows`). - When `safaridriver` fails to pass all of the above checks, both close the session and kill the `safaridriver` process. Killing the process alone leaves Safari windows open. Closing the session alone leaves `safaridriver` processes open. - When tests are finished use `quit()` instead of `window.close()`, because the latter does not close the session.
Improve safaridriver launch sequence as follows: - Fix retry: the previous version would call `_startDriverProcess` recursively from within a listener to the stderr output. But by then the outer `_startDriverProcess` call would have completed its future, so the retry mechanism would kick in while tests are already running. - Wait for `safaridriver` server process to start listening and responding to WebDriver commands (using `/status` as the smoke test). - Smoke-test the driver session by attempting to list all windows (`WebDriver.windows`). - When `safaridriver` fails to pass all of the above checks, both close the session and kill the `safaridriver` process. Killing the process alone leaves Safari windows open. Closing the session alone leaves `safaridriver` processes open. - When tests are finished use `quit()` instead of `window.close()`, because the latter does not close the session.
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
Roll Flutter from 892f9c1 to e8f34a9 (71 revisions) flutter/flutter@892f9c1...e8f34a9 2025-02-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (#163127)" (flutter/flutter#163133) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from f31c733c86c4 to 25937c31f153 (2 revisions) (flutter/flutter#163127) 2025-02-12 jonnywang@google.com Update .ci.yaml to support Fuchsia cherrypick branches (flutter/flutter#163000) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 6f17f2ebb2e5 to f31c733c86c4 (1 revision) (flutter/flutter#163112) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from a9dbb2479c26 to 6f17f2ebb2e5 (2 revisions) (flutter/flutter#163109) 2025-02-12 jonahwilliams@google.com [devicelab] dont strip symbols in platform views layout test. (flutter/flutter#163101) 2025-02-12 jonahwilliams@google.com [Impeller] mirror tile mode requires highp for Adreno. (flutter/flutter#163066) 2025-02-12 engine-flutter-autoroll@skia.org Roll Skia from 5b56d9a91633 to a9dbb2479c26 (6 revisions) (flutter/flutter#163100) 2025-02-12 engine-flutter-autoroll@skia.org Roll Dart SDK from d9d7f103b6b7 to fcef25f18e4d (3 revisions) (flutter/flutter#163098) 2025-02-12 matanlurey@users.noreply.github.com Generate a correct `.flutter-plugin-dependencies` file for iOS/macOS projects (flutter/flutter#162834) 2025-02-12 matanlurey@users.noreply.github.com Remove unsound artifacts, remove `*Sound` qualifier. (flutter/flutter#163015) 2025-02-12 chinmaygarde@google.com [Impeller] libImpeller: Add support for Metal and Vulkan rendering. (flutter/flutter#161547) 2025-02-11 fluttergithubbot@gmail.com Marks Mac_benchmark basic_material_app_macos__compile to be flaky (flutter/flutter#162365) 2025-02-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#163083) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds hasSelectedState parameter to matchesSemantics for migration (flutter/flutter#163014) 2025-02-11 koji.wakamiya@gmail.com fix: Dispose codec after completing frame creation (flutter/flutter#159945) 2025-02-11 41930132+hellohuanlin@users.noreply.github.com [ios][secure_paste]show menu item based on info sent from framework (flutter/flutter#161103) 2025-02-11 christopherfujino@gmail.com Update conductor to support monorepos (flutter/flutter#161704) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp tapping, again, and add test. (flutter/flutter#163035) 2025-02-11 2049220+sigmundch@users.noreply.github.com Add new builder for experiment with dynamic modules. (flutter/flutter#162855) 2025-02-11 jason-simmons@users.noreply.github.com Roll vulkan-deps to 9edf248c597b (flutter/flutter#162549) 2025-02-11 47866232+chunhtai@users.noreply.github.com Adds dialog and alertdialog role (flutter/flutter#162692) 2025-02-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 99789828cc95 to d9d7f103b6b7 (12 revisions) (flutter/flutter#163060) 2025-02-11 bkonyi@google.com [ Widget Preview ] Cleanup PreviewDetector code (flutter/flutter#163050) 2025-02-11 matanlurey@users.noreply.github.com Fix `SkiaException` -> `TestFailure`, add tests. (flutter/flutter#163054) 2025-02-11 jonahwilliams@google.com [Android] fix hcpp overlay layer intersection. (flutter/flutter#163024) 2025-02-11 bkonyi@google.com [ Widget Preview ] Update generated scaffold project to include early preview rendering (flutter/flutter#162847) 2025-02-11 matej.knopp@gmail.com [Embedder] Implement merged platform and UI thread (flutter/flutter#162944) 2025-02-11 jonahwilliams@google.com [Android] Remove overlay when platform views are removed from screen. (flutter/flutter#162908) 2025-02-11 jason-simmons@users.noreply.github.com Roll Dart to 3.8.0-76.0.dev (flutter/flutter#162913) 2025-02-11 jonahwilliams@google.com [Android] add HCPP platform views benchmark and integration test. (flutter/flutter#163018) 2025-02-11 engine-flutter-autoroll@skia.org Roll Skia from 8c377e8bedd2 to 5b56d9a91633 (9 revisions) (flutter/flutter#163021) 2025-02-11 matanlurey@users.noreply.github.com Try golden-testing on a Mokey (`bringup: true`), retry on an emulator (flutter/flutter#163029) 2025-02-11 robert.ancell@canonical.com Fix Linux keyboard support for AltGr (flutter/flutter#162495) 2025-02-11 robert.ancell@canonical.com Update gen_keycodes output to new engine location. (flutter/flutter#162479) 2025-02-10 jonahwilliams@google.com [Android] add runtime flag to determine if HCPP is supported. (flutter/flutter#163004) 2025-02-10 koji.wakamiya@gmail.com [iOS][Engine] Fix view removal process for AutofillContextAction.cancel (flutter/flutter#160653) 2025-02-10 matanlurey@users.noreply.github.com Re-land #162644: Remove `--verbose` from devicelab task executions. (flutter/flutter#163017) 2025-02-10 reidbaker@google.com Include device lab version for how to run test (flutter/flutter#163010) 2025-02-10 jacksongardner@google.com Change the default optimization level to `-O2` for wasm in release mode. (flutter/flutter#162917) 2025-02-10 yjbanov@google.com [web] robustify safaridriver launch sequence (flutter/flutter#162919) 2025-02-10 jakemac@google.com Return more eagerly when toggling service extensions (flutter/flutter#162774) 2025-02-10 goderbauer@google.com Fix doc reference typos (flutter/flutter#162893) 2025-02-10 engine-flutter-autoroll@skia.org Roll Skia from 180ed4fc263d to 8c377e8bedd2 (4 revisions) (flutter/flutter#162998) 2025-02-10 matanlurey@users.noreply.github.com FYI matanlurey (does not require review, but probably should) on dev/test infra. (flutter/flutter#162642) 2025-02-10 30870216+gaaclarke@users.noreply.github.com [Impeller] rrect_blur: scale max radius clamp by transform (flutter/flutter#161238) ...
Improve safaridriver launch sequence as follows:
_startDriverProcessrecursively from within a listener to the stderr output. But by then the outer_startDriverProcesscall would have completed its future, so the retry mechanism would kick in while tests are already running.safaridriverserver process to start listening and responding to WebDriver commands (using/statusas the smoke test).WebDriver.windows).safaridriverfails to pass all of the above checks, both close the session and kill thesafaridriverprocess. Killing the process alone leaves Safari windows open. Closing the session alone leavessafaridriverprocesses open.quit()instead ofwindow.close(), because the latter does not close the session.