Skip to content

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function.#162578

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
ksokolovskyi:fix-semantics-node-update-with-role
Feb 5, 2025
Merged

Add role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function.#162578
auto-submit[bot] merged 1 commit intoflutter:masterfrom
ksokolovskyi:fix-semantics-node-update-with-role

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Feb 2, 2025

Fixes #162577

Description

  • Adds role check in SemanticsNode._isDifferentFromCurrentSemanticAnnotation function.
  • Adds SemanticsNode.debugIsDirty property to check in tests whether the node is marked as dirty.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) labels Feb 2, 2025
@goderbauer goderbauer requested a review from chunhtai February 4, 2025 23:05
chunhtai
chunhtai approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/semantics/semantics.dart
_areUserActionsBlocked != config.isBlockingUserActions ||
_headingLevel != config._headingLevel ||
_linkUrl != config._linkUrl ||
_linkUrl != config._linkUrl;
Copy link
Contributor

@chunhtai chunhtai Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, nice catch. I made a copy paste error

@chunhtai chunhtai requested a review from hannah-hyj February 5, 2025 21:01
hannah-hyj
hannah-hyj approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@hannah-hyj hannah-hyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 5, 2025
Merged via the queue into flutter:master with commit 243413f Feb 5, 2025
76 of 77 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 5, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
e78c4aa 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
a77bdb1 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
f5ad21a 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 6, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
80c5468 
…icAnnotation function. (flutter/flutter#162578)
@ksokolovskyi
Copy link
Contributor Author

ksokolovskyi commented Feb 6, 2025

@chunhtai @hannah-hyj, thanks a lot for the review!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
eaba6cc 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
efd67d1 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
39a4536 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
6b9a2b2 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
68b6c1d 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
76de494 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
6f2d697 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
da73817 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
2646eb5 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
fb3266a 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
8bdac98 
…icAnnotation function. (flutter/flutter#162578)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
70440a9 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
db2c8ff 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
bd5fc66 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
b1c7c7d 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
f1f866b 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
a12a508 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
74f64d4 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
93ced67 
…icAnnotation function. (flutter/flutter#162578)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
243413f Add role check in SemanticsNode._isDifferentFromCurrentSemant…
0949ab6 
…icAnnotation function. (flutter/flutter#162578)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

@hannah-hyj hannah-hyj hannah-hyj approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SemanticsNode.updateWith does not mark node as dirty when only role changes.

3 participants

@ksokolovskyi @chunhtai @hannah-hyj