Skip to content

Improve slider's value indicator display test#139198

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
hgraceb:improve_slider_test
Dec 11, 2023
Merged

Improve slider's value indicator display test#139198
auto-submit[bot] merged 3 commits intoflutter:masterfrom
hgraceb:improve_slider_test

Conversation

@hgraceb
Copy link
Member

@hgraceb hgraceb commented Nov 29, 2023

The previous test for #128137 does not effectively regress and verify #123313 because the issue is specific to desktop platforms.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 29, 2023
gspencergoog
gspencergoog reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/flutter/test/material/slider_test.dart Outdated
Copy link
Contributor

@gspencergoog gspencergoog Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, instead of doing this here, can you add a kind parameter to tapAt and tap in the flutter_test package and pass it into the createGesture there? Then it'll be a more generic solution that can be used by others.

Copy link
Member Author

@hgraceb hgraceb Dec 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a kind parameter to tapAt and tap. Also press, longPress, and longPressAt which similar.

Copy link
Member Author

@hgraceb hgraceb Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gspencergoog I'm sorry, but it has been one week already. Should I do anything else for the PR?

@github-actions github-actions bot added the a: tests "flutter test", flutter_test, or one of our tests label Dec 2, 2023
@hgraceb hgraceb requested a review from gspencergoog December 3, 2023 06:18
gspencergoog
gspencergoog approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks for the PR!

cbracken
cbracken approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 11, 2023
@auto-submit auto-submit bot merged commit 4252aa0 into flutter:master Dec 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
407def0 
…r#139198)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
6c1e168 
…r#139198)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
b000e11 
…r#139198)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
2e85d42 
…r#139198)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 11, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2023
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
21d92cf 
…r#139198)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Dec 12, 2023
@engine-flutter-autoroll
Manual roll Flutter from c642f4e to 9719097 (25 revisions) (#5648)
80aa46a 
Manual roll requested by dit@google.com

flutter/flutter@c642f4e...9719097

2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) (flutter/flutter#139936)
2023-12-11 rmolivares@renzo-olivares.dev Fix SelectionArea select-word edge cases (flutter/flutter#136920)
2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) (flutter/flutter#139933)
2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) (flutter/flutter#139931)
2023-12-11 31859944+LongCatIsLooong@users.noreply.github.com Use dart analyze package for `num.clamp` (flutter/flutter#139867)
2023-12-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139926)
2023-12-11 jhy03261997@gmail.com Handle the case when _CupertinoBackGestureDetector is disposed during the drag.  (flutter/flutter#139585)
2023-12-11 barpac02@gmail.com Add accessibility identifier to `SemanticsProperties` (flutter/flutter#138331)
2023-12-11 38378650+hgraceb@users.noreply.github.com Improve slider's value indicator display test (flutter/flutter#139198)
2023-12-11 mateusfccp@gmail.com Add `enabled` property to `ExpansionTile` (flutter/flutter#139519)
2023-12-11 engine-flutter-autoroll@skia.org Roll Packages from 6cd0657 to cb6dbcd (9 revisions) (flutter/flutter#139911)
2023-12-11 engine-flutter-autoroll@skia.org Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) (flutter/flutter#139891)
2023-12-10 engine-flutter-autoroll@skia.org Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) (flutter/flutter#139885)
2023-12-09 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#139864)
2023-12-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) (flutter/flutter#139863)
2023-12-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) (flutter/flutter#139853)
2023-12-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) (flutter/flutter#139851)
2023-12-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) (flutter/flutter#139847)
2023-12-09 engine-flutter-autoroll@skia.org Roll Flutter Engine from e9cb19fa637a to 503584615fd7 (1 revision) (flutter/flutter#139837)
2023-12-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7dc51b85a634 to e9cb19fa637a (1 revision) (flutter/flutter#139831)
2023-12-08 xilaizhang@google.com [flutter release] Add cherry pick template for pull request description (flutter/flutter#139590)
2023-12-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 03c5f016e919 to 7dc51b85a634 (1 revision) (flutter/flutter#139829)
2023-12-08 goderbauer@google.com Add Overlay.wrap for convenience (flutter/flutter#139823)
2023-12-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 72da960e2ef2 to 03c5f016e919 (1 revision) (flutter/flutter#139826)
2023-12-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5dd2619c282b to 72da960e2ef2 (1 revision) (flutter/flutter#139821)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@hgraceb hgraceb deleted the improve_slider_test branch December 12, 2023 04:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
4252aa0 Improve slider's value indicator display test (flutter/flutte…
fe909c0 
…r#139198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hgraceb @cbracken @gspencergoog