[web] New HtmlElementView.fromTagName constructor#130513
Merged
auto-submit[bot] merged 12 commits intoflutter:masterfrom Aug 7, 2023
Merged
[web] New HtmlElementView.fromTagName constructor#130513auto-submit[bot] merged 12 commits intoflutter:masterfrom
auto-submit[bot] merged 12 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
the
framework
ditman
reviewed
Jul 14, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
Small comment: would defining the default factories in the engine simplify the framework code?
ditman
reviewed
Jul 21, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
I think this one is ready to go. Only one comment about attempting to make the new extension private so it doesn't show in docs.flutter.dev.
mdebbar
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jul 26, 2023
Convenient default factories for creating DOM element from a given tag name. Required by flutter/flutter#130513 Part of flutter/flutter#127030
ditman
approved these changes
Jul 27, 2023
Member
ditman
left a comment
ditman
left a comment
There was a problem hiding this comment.
I still like this after the latest changes. LGTM!
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 8, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 8, 2023
flutter/flutter@ad0aa8d...436df69 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9c83d90b01bd to 146c4c9487fc (6 revisions) (flutter/flutter#132112) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from c27109291e22 to 9c83d90b01bd (5 revisions) (flutter/flutter#132108) 2023-08-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from be085f6699b6 to c27109291e22 (3 revisions) (flutter/flutter#132086) 2023-08-08 jesus_sguerrero@hotmail.com Revert "Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus" (flutter/flutter#132104) 2023-08-08 jonahwilliams@google.com [Impeller] add drawVertices and drawAtlas benchmarks. (flutter/flutter#132080) 2023-08-07 47866232+chunhtai@users.noreply.github.com Adds more documentations around ignoreSemantics deprecations. (flutter/flutter#131287) 2023-08-07 mdebbar@google.com [web] New HtmlElementView.fromTagName constructor (flutter/flutter#130513) 2023-08-07 katelovett@google.com Move mock canvas to flutter_test (flutter/flutter#131631) 2023-08-07 matej.knopp@gmail.com Add static_path_tessellation macrobenchmark (flutter/flutter#131837) 2023-08-07 mdebbar@google.com [web] Remove usage of `ui.webOnlyInitializePlatform()` (flutter/flutter#131344) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39a575f65d50 to be085f6699b6 (1 revision) (flutter/flutter#132069) 2023-08-07 jmccandless@google.com Android context menu theming and visual update (flutter/flutter#131816) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 39ce1c097bce to 39a575f65d50 (2 revisions) (flutter/flutter#132064) 2023-08-07 xhzq233@qq.com CupertinoContextMenu improvement (flutter/flutter#131030) 2023-08-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5b47c0577060 to 39ce1c097bce (3 revisions) (flutter/flutter#132057) 2023-08-07 xming@google.com Slider should check `mounted` before start interaction (flutter/flutter#132010) 2023-08-07 engine-flutter-autoroll@skia.org Roll Packages from ce53da1 to d7ee75a (7 revisions) (flutter/flutter#132058) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
…r#43828) Convenient default factories for creating DOM element from a given tag name. Required by flutter/flutter#130513 Part of flutter/flutter#127030
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This wraps up the platform view improvements discussed in #127030.
HtmlElementViewinto 2 files that are conditionally imported.tagNameparameter.HtmlElementView.fromTagName()constructor that uses the default factories to create DOM elements.Depends on flutter/engine#43828
Fixes #127030