Return null rather than fall off nullable onError catchError handler.#111581
Return null rather than fall off nullable onError catchError handler.#111581auto-submit[bot] merged 3 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@srawlins Could you do the same in previous TODOs? Some of them might require for more reasonable fix which affects behavior but some of them are not. |
Ignore body_might_complete_normally_catch_error violations
Related to #105750
This onError catchError should return a value.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.