Assign debugCreator for more layers#101899
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
26c1813 to
6ae1c91
Compare
goderbauer
left a comment
There was a problem hiding this comment.
Can you please add a test so we don't accidentally remove this again? Thanks!
eb92d35 to
50e4ff4
Compare
|
@Piinks Could you do a secondary review? |
A little patch to assign values to layer's debugCreator properties, such as OpacityLayer、ImageFilterLayer etc.
Take ImageFilterLayer as an example.
Now:
After merged:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.