This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Fix concurrent modification exception#52247
Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom Apr 20, 2024
cbracken:et-concurrent-modification
Merged
[et] Fix concurrent modification exception#52247auto-submit[bot] merged 2 commits intoflutter:mainfrom cbracken:et-concurrent-modification
auto-submit[bot] merged 2 commits intoflutter:mainfrom
cbracken:et-concurrent-modification
Conversation
johnmccutchan
approved these changes
Apr 20, 2024
We cannot modify the list of build targets as we're iterating over it. Instead of removing non-test/non-executable elements, instead we add executable test targets to a separate testTargets list and use that.
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 20, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 20, 2024
flutter/engine@4d34b6d...499edda 2024-04-20 chris@bracken.jp [et] Fix concurrent modification exception (flutter/engine#52247) 2024-04-20 johnstiles@google.com Remove SkScalarIsFinite from Flutter Engine. (flutter/engine#52270) 2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) (flutter/engine#52280) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…7105) flutter/engine@4d34b6d...499edda 2024-04-20 chris@bracken.jp [et] Fix concurrent modification exception (flutter/engine#52247) 2024-04-20 johnstiles@google.com Remove SkScalarIsFinite from Flutter Engine. (flutter/engine#52270) 2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) (flutter/engine#52280) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot modify the list of build targets as we're iterating over it. Instead of removing non-test/non-executable elements, instead we add executable test targets to a separate testTargets list and use that.
Noticed while working on: flutter/flutter#147071
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.