This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Handle interleaved movement and gesture events#52201
Merged
knopp merged 3 commits intoflutter:mainfrom Apr 17, 2024
Merged
[macOS] Handle interleaved movement and gesture events#52201knopp merged 3 commits intoflutter:mainfrom
knopp merged 3 commits intoflutter:mainfrom
Conversation
knopp
requested review from
cbracken and
moffatman
and removed request for
cbracken
Member
Author
|
@moffatman, can you think of any unwanted side-effects of not calling |
knopp
force-pushed
the
macos_movement_and_scroll_event_separate
branch
from
d55bbc3 to
7e9a78c
Compare
cbracken
approved these changes
Apr 17, 2024
shell/platform/darwin/macos/framework/Source/FlutterViewControllerTest.mm
Show resolved
Hide resolved
cbracken
reviewed
Apr 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2024
flutter/engine@cc73c5c...9edcb26 2024-04-17 bdero@google.com [Impeller] Delete `EntityPass::AddSubpassInline`. (flutter/engine#52182) 2024-04-17 skia-flutter-autoroll@skia.org Roll Skia from 2790777048d3 to 0c56bd472923 (4 revisions) (flutter/engine#52203) 2024-04-17 matej.knopp@gmail.com [macOS] Handle interleaved movement and gesture events (flutter/engine#52201) 2024-04-17 bdero@google.com [Impeller] Remove old clip height tracking from Entity. (flutter/engine#52178) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega
pushed a commit
to gilnobrega/flutter
that referenced
this pull request
Apr 22, 2024
…6946) flutter/engine@cc73c5c...9edcb26 2024-04-17 bdero@google.com [Impeller] Delete `EntityPass::AddSubpassInline`. (flutter/engine#52182) 2024-04-17 skia-flutter-autoroll@skia.org Roll Skia from 2790777048d3 to 0c56bd472923 (4 revisions) (flutter/engine#52203) 2024-04-17 matej.knopp@gmail.com [macOS] Handle interleaved movement and gesture events (flutter/engine#52201) 2024-04-17 bdero@google.com [Impeller] Remove old clip height tracking from Entity. (flutter/engine#52178) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#146893
The crash happens, because with magic mouse, it is quite common to receive
mouseExited:event while the gesture event is still in progress. This would reset the gesture state while the gesture event is still active, leading to assertion when the gesture event ends.The state machine assumes that when mouse exists that also ends any gesture events. However that is not the case with magic mouse, which handles the movement and gesture events separately.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.