Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
38846ea to
292a369
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
292a369 to
e6ddd23
Compare
|
Would the performance be acceptable if this invoked the When I run |
|
Does |
|
No - it should only read the local repository filesystem |
|
Closing in favor of #51175 |
Avoids GN invoking python scripts that run git commands to determine git hashes. Instead the git hashes are saved in files by
gclient sync, and then read out of the files into GN arguments by thegnscript.Part of flutter/flutter#144430