This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] migrate blur to calculating coefficients on the cpu#49512
Merged
auto-submit[bot] merged 16 commits intoflutter:mainfrom Jan 4, 2024
Merged
[Impeller] migrate blur to calculating coefficients on the cpu#49512auto-submit[bot] merged 16 commits intoflutter:mainfrom
auto-submit[bot] merged 16 commits intoflutter:mainfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
jonahwilliams
approved these changes
Jan 4, 2024
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM
Uber-nit: kernel as a name is sort of ambiguous. If we're able to get rid of the old gaussian, can we reclaim that name later?
Member
Author
Here's the thinking behind it. The fragment shader, by virtue of removing all the blur math, was left with just applying a Kernel. It's exactly the name for what it does. There are a few effects that can be implemented with just a Kernel and given Impeller's ethos of having a limited static set of shaders, it made more sense, to me, to make it available for everyone instead of naming it something specific. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 4, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 5, 2024
flutter/engine@0bbb4d6...f60d9a9 2024-01-04 30870216+gaaclarke@users.noreply.github.com [Impeller] migrate blur to calculating coefficients on the cpu (flutter/engine#49512) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#131580
This factors out the gaussian blur fragment shader to be a more generic kernel fragment shader. We can't use this for the old gaussian blur because it's kernel is unbounded in one dimension. I implemented this by passing in the coefficients into the UBO so it can't support that.
Profile after change:
This is a 13% (21.25 / 25 ) drop in
average_gpu_frame_timefrom the last profile in #49299.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.