Explicitly encode SkImages in SkPictures as PNG#45511
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
LGTM. I don't know of other spots we might be encoding pictures as SKPs but @flar might know more.
|
I didn't find any others with |
flutter/engine@71bea01...f0b718e 2023-09-07 kjlubick@users.noreply.github.com Explicitly encode SkImages in SkPictures as PNG (flutter/engine#45511) 2023-09-07 skia-flutter-autoroll@skia.org Roll Skia from 9a41a83f96d7 to 16df0c27bc0e (3 revisions) (flutter/engine#45537) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Is it important to support this mechanism? Should we deprecate it and replace it with something either DL or Impeller-based? |
|
We can decide that separately. This is just keeping an existing feature going. |
3 participants
Skia plans to stop the default behavior of encoding SkImages in SkPictures using a PNG encoder. To preserve that behavior, clients need to explicitly set an SkSerialProc to do so.
This was the only location I could find in Flutter which serialized an skp.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.