This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Run clangd tidy, opting out in 2 cases.#44351
Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom Aug 3, 2023
Merged
[Impeller] Run clangd tidy, opting out in 2 cases.#44351auto-submit[bot] merged 1 commit intoflutter:mainfrom
auto-submit[bot] merged 1 commit intoflutter:mainfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
changed the title
chinmaygarde
approved these changes
Aug 3, 2023
matanlurey
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 3, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 4, 2023
flutter/engine@0c1de9b...4c62dd8 2023-08-03 matanlurey@users.noreply.github.com [Impeller] Run clangd tidy, opting out in 2 cases. (flutter/engine#44351) 2023-08-03 1961493+harryterkelsen@users.noreply.github.com Reland "[web] Update text editing test skips" (flutter/engine#37655) 2023-08-03 jason-simmons@users.noreply.github.com [Impeller] Discard invalid command buffer handles after destroying a command pool (flutter/engine#44194) 2023-08-03 skia-flutter-autoroll@skia.org Roll Skia from bae32428c1c7 to 3b3c1a617544 (1 revision) (flutter/engine#44345) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Many `#include`s, particularly in the `impeller/renderer/backend/vulkan/...` directory, had existing `clangd` lint violations. The most frequent and easiest to fix appears to be https://clangd.llvm.org/guides/include-cleaner. --- Note that I used `// IWYU pragma: keep.` in two places where `clangd` wasn't able to tell something was in use. In other cases you'll see additions because files were relying on transitive includes that are removed in this PR, but there should be 0 behavioral changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many
#includes, particularly in theimpeller/renderer/backend/vulkan/...directory, had existingclangdlint violations.The most frequent and easiest to fix appears to be https://clangd.llvm.org/guides/include-cleaner.
Note that I used
// IWYU pragma: keep.in two places whereclangdwasn't able to tell something was in use. In other cases you'll see additions because files were relying on transitive includes that are removed in this PR, but there should be 0 behavioral changes!