This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add interactive DrawPaint blend test#42031
Merged
bdero merged 1 commit intoflutter:mainfrom May 15, 2023
Merged
Conversation
bdero
force-pushed
the
bdero/drawpaint-interactive
branch
3 times, most recently
from
807c2ba to
8e01fb3
Compare
bdero
force-pushed
the
bdero/drawpaint-interactive
branch
from
8e01fb3 to
c1e02b5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2023
flutter/engine@00f20fb...027ca79 2023-05-15 godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CaseyHillers
pushed a commit
to CaseyHillers/flutter
that referenced
this pull request
May 24, 2023
…6876) flutter/engine@00f20fb...027ca79 2023-05-15 godofredoc@google.com Use release_build and os dimension consistently. (flutter/engine#42012) 2023-05-15 bdero@google.com [Impeller] Add interactive DrawPaint blend test (flutter/engine#42031) 2023-05-15 bdero@google.com [Impeller] Limit subpass textures and backdrop blurs to the current clip (flutter/engine#42039) 2023-05-15 skia-flutter-autoroll@skia.org Roll Dart SDK from c302a0252785 to d2b2ac829842 (1 revision) (flutter/engine#42051) 2023-05-15 ychris@google.com Upload xcresults to LUCI cloud storage (flutter/engine#41647) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made this to help debugging clear color problems and I've had it sitting around in my stage for a few days. Today, it ended up leading me to discover several other issues. For example, advanced blends are doing nothing in this case...