Make the Linux GTK widget focusable#40163
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
robert-ancell
left a comment
There was a problem hiding this comment.
There were a lot of focus related calls that seemed redundant in the code before the simplification, I guess I took out one too many. Confirmed it was broken and this fixes it.
|
Adding a test for Hopefully this PR can get a test exemption, but the test proposed by @cbracken should be sufficient if not. |
Handling of keyboard focus for Flutter text fields appears to have regressed with #39473, which removed the call to
gtk_widget_set_can_focus