This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Mark move-only classes as such#39734
Merged
cbracken merged 1 commit intoflutter:mainfrom Feb 18, 2023
cbracken:disallow-copy-and-assign
Merged
[macOS] Mark move-only classes as such#39734cbracken merged 1 commit intoflutter:mainfrom cbracken:disallow-copy-and-assign
cbracken merged 1 commit intoflutter:mainfrom
cbracken:disallow-copy-and-assign
Conversation
Contributor
|
test-exempt: code refactor with no semantic change |
Applies the FML_DISALLOW_COPY_AND_ASSIGN to non-POD types in the macOS embedder. Specifically the following three accessibility-related classes: * FlutterPlatformNodeDelegateMac * FlutterTextPlatformNode * AccessibilityBridgeMac No new tests since no semantic change. Only has the compile-time effect of preventing copying of classes intended to be move-only.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 18, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 18, 2023
* 974274d [macOS] Mark move-only classes as such (flutter/engine#39734) * d5316b6 add lint check for python files (flutter/engine#39736) * 9a3c3e4 Roll Skia from 4b79e398dfe0 to 733a19f6a625 (9 revisions) (flutter/engine#39740)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the FML_DISALLOW_COPY_AND_ASSIGN to non-POD types in the macOS embedder. Specifically the following three accessibility-related classes:
No new tests since no semantic change. Only has the compile-time effect of preventing copying of classes intended to be move-only.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.