This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
This reverts commit c7c21e5.
Member
Author
|
Given the comment from @utzcoz on flutter/flutter#114036, I think we should land this revert until a fix is investigated. The test is flaking on every build, causing the Android debug shard to be the long pole for CI cycle time. |
jason-simmons
approved these changes
Oct 26, 2022
utzcoz
reviewed
Oct 26, 2022
Contributor
utzcoz
left a comment
utzcoz
left a comment
There was a problem hiding this comment.
LGTM. I will investigate it with Robolectric 4.9 landing directly.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #34272
Speculative revert for flutter/flutter#114036
cc @utzcoz @jason-simmons