This repository was archived by the owner on Feb 25, 2025. It is now read-only.
NNBD migration for //testing#34766
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Jul 20, 2022
Merged
Conversation
Member
|
Looks like the benchmark runner has some non-null-safe dependencies. |
Contributor
Author
|
metrics_center is assuming some values can't be null in the JSON when in fact they can. For example, in sound null safety it fails to parse a benchmark json stub like {
"name": "ParagraphFixture/TextBigO_RMS",
"family_index": 5,
"per_family_instance_index": 0,
"run_name": "ParagraphFixture/TextBigO",
"run_type": "aggregate",
"repetitions": 1,
"threads": 1,
"aggregate_name": "RMS",
"aggregate_unit": "percentage",
"rms": 4.8948864875330522e-01
},because it has no It will need to be patched and rolled into the engine. |
Contributor
Author
|
flutter/packages#2347 needs to roll into this to work. |
Contributor
Author
|
This looks like it'll be green now. |
jason-simmons
approved these changes
Jul 20, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two of the items in flutter/flutter#71507
verify_exported seems to "just work." Unfortunately, I don't think it will be run in CI until post submit and I may not have covered all the cases exercised there in my quick local test.
The parse_and_send stuff was relatively trivial to migrate. The fallout if there is anything bad there is we may not get benchmark data showing up.