This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Handle SurfaceView in a VirtualDisplay"#34333
Closed
bparrishMines wants to merge 2 commits intomainfrom
Closed
Revert "Handle SurfaceView in a VirtualDisplay"#34333bparrishMines wants to merge 2 commits intomainfrom
bparrishMines wants to merge 2 commits intomainfrom
Conversation
This reverts commit e986f43.
Contributor
|
Could the failure be expected? The patch being reverted here was known to fix some issues with how google_maps_flutter in particular did positioning. |
Contributor
|
(build failures appear to be unrelated, merging to head should resolve them) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #33599
This is most likely causing a test failure in
google_maps_flutter:Test location: https://github.com/flutter/plugins/blob/main/packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart#L428
And preventing Flutter from rolling into plugins: flutter/plugins#6048.
I haven't ran this specific commit locally, but the test fails after this PR rolls into Flutter: flutter/flutter#106574