This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
chinmaygarde
approved these changes
Jun 4, 2022
Contributor
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
This is great. Left a few comments inline but they are mostly nits.
| return BlendHardLight(dst, src); | ||
| } | ||
|
|
||
| #include "advanced_blend.glsl" No newline at end of file |
| #include "advanced_blend_utils.glsl" | ||
|
|
||
| vec3 Blend(vec3 dst, vec3 src) { | ||
| vec3 D = MixComponents(((16 * dst - 12) * dst + 4) * dst, // |
Contributor
There was a problem hiding this comment.
I had to look up which variant you'd used on Wikipedia. I think it'd be good to document this is W3C variant here. Adding documentation for all blend modes either inline here or in a new doc in the docs/ folder would be great (in a separate patch is fine).
Contributor
Author
There was a problem hiding this comment.
Yeah, all of these come from https://www.w3.org/TR/compositing-1/#blendingseparable. Added comments to each of these shaders linking the relevant sections. Documenting this along with the blend situation in general seems like a good idea -- I'll start working on a doc add it in a later patch.
bdero
force-pushed
the
bdero/add-seperable-blends
branch
from
2c26386 to
ae5cb9d
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 4, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is the question... and the answer is yes.
Adds all the remaining "separable" blend modes. I plan to land the 4 remaining ("non-separable") blends (Hue, Saturation, Color, and Luminosity) in a separate patch.
Screen.Recording.2022-06-03.at.5.01.56.PM.mov