Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ci.yaml] Fix xcode 13 cache to not contain dashes #32325

Merged
CaseyHillers merged 2 commits into from
Mar 29, 2022
Merged

[ci.yaml] Fix xcode 13 cache to not contain dashes #32325

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612ed47
[ci.yaml] Fix xcode 13 cache to not contain dashes
Mar 29, 2022
082ddf7
last fixes
Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ platform_properties:
{"name":"osx_sdk_13a233_13_15","path":"osx_sdk"},
{"name":"builder_mac_engine","path":"builder"},
{"name":"openjdk","path":"java"},
{"name":"xcode_runtime_ios-13-0","path":"xcode_runtime_ios-13-0"},
Copy link
Member

@jmagman jmagman Mar 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the recipe module is expecting ios- with a dash?

'iOS %s.simruntime' % version.lower().replace('ios-', '').replace('-', '.')

https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#211

Copy link
Member

@jmagman jmagman Mar 29, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nevermind that's coming from the runtime_versions property, not the cache.

{"name":"xcode_runtime_ios-15-0","path":"xcode_runtime_ios-15-0"}
{"name":"xcode_runtime_ios_13_0","path":"xcode_runtime_ios_13_0"},
{"name":"xcode_runtime_ios_15_0","path":"xcode_runtime_ios_15_0"}
]
# CIPD flutter_internal/java/openjdk/$platform
dependencies: >-
Expand Down