This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[iOS] Fixes state restoration not work#31511
Merged
fluttergithubbot merged 2 commits intoflutter:mainfrom Mar 18, 2022
Merged
Conversation
Contributor
|
Can you describe or link the issue please? |
Contributor
|
The patch does look fine to me. I am just not sure what issue it is cross referenced to. |
Member
Author
@chinmaygarde We added the feature of state restoration on iOS, but when we enable it and restore the state, it crashes and throws the exception like below. State restoration decoder seems can't use the |
chinmaygarde
approved these changes
Mar 17, 2022
ba517d6 to
b9e29d5
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, the
coderofdecodeRestorableStateWithCoderinFlutterViewControllerseems is not support to useencode/decodeDataObject, it would throw exception. So we changed to bytes encoded.Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.