Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

PhysicalShapeLayer: Only push cull rect during diff if clipping#29783

Merged
knopp merged 1 commit intoflutter:mainfrom
knopp:fix_physical_shape_layer_diff
Nov 17, 2021
Merged

PhysicalShapeLayer: Only push cull rect during diff if clipping#29783
knopp merged 1 commit intoflutter:mainfrom
knopp:fix_physical_shape_layer_diff

Conversation

@knopp
Copy link
Member

@knopp knopp commented Nov 17, 2021

Fixes flutter/flutter#93758

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Nov 17, 2021
@knopp knopp requested a review from iskakaushik November 17, 2021 13:17
iskakaushik
iskakaushik approved these changes Nov 17, 2021
View reviewed changes
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Nov 17, 2021
@knopp knopp merged commit 88644c8 into flutter:main Nov 17, 2021
@knopp knopp deleted the fix_physical_shape_layer_diff branch November 17, 2021 13:46
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 17, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 17, 2021
@engine-flutter-autoroll
88644c8 PhysicalShapeLayer: Only push cull rect during diff if clippi…
83066ec 
…ng (flutter/engine#29783)
xster pushed a commit to xster/engine that referenced this pull request Nov 18, 2021
@knopp @xster
PhysicalShapeLayer: Only push cull rect during diff if clipping (flut…
a9afaa8 
…ter#29783)
xster added a commit that referenced this pull request Nov 20, 2021
@xster @knopp
Cherrypick #29783 to flutter-2.8-candidate.6 (#29812)
e04bc2b 
* PhysicalShapeLayer: Only push cull rect during diff if clipping (#29783)

* add branch to test for CI

Co-authored-by: Matej Knopp <matej.knopp@gmail.com>
xster pushed a commit to xster/engine that referenced this pull request Nov 23, 2021
@knopp @xster
PhysicalShapeLayer: Only push cull rect during diff if clipping (flut…
202caa0 
…ter#29783)
xster added a commit that referenced this pull request Nov 23, 2021
@xster
Cherrypick #29783 and #29862 to flutter-2.8-candidate.7 (#29898)
d702022 
Request from b/207432361
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@iskakaushik iskakaushik iskakaushik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Popup menu items remain on screen after dismissing

2 participants

@knopp @iskakaushik