This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Eliminate error message for missing CMAP table#25403
Merged
cbracken merged 1 commit intoflutter:masterfrom Apr 3, 2021
cbracken:cmap-spam
Merged
Eliminate error message for missing CMAP table#25403cbracken merged 1 commit intoflutter:masterfrom cbracken:cmap-spam
cbracken merged 1 commit intoflutter:masterfrom
cbracken:cmap-spam
Conversation
CMAP tables are a component of fonts which map character codes to glyph indices used in the font. In cases where this is missing for a font that we attempt to load, there is not much gained by logging this. It's also a common source of false positive bug reports and bug reports with misleading symptoms in Flutter, such as flutter/flutter#78929 Instead of logging the error, simply suppress it, since it's not actionable by the user. CMAP Reference: https://docs.microsoft.com/en-us/typography/opentype/spec/cmap
Contributor
|
Can we test this somehow? Sort of "golden files" for logs that makes sure nothing unexpected is logged? It would also catch other kinds of regressions with logging... |
Member
Author
Funny you should mention that... we don't currently have testing for logs to stdout by C++ code, but as of #25402, we will have the ability to capture Dart logs :) I'll give this some thought. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2021
duanqz
pushed a commit
to duanqz/engine
that referenced
this pull request
Apr 16, 2021
CMAP tables are a component of fonts which map character codes to glyph indices used in the font. In cases where this is missing for a font that we attempt to load, there is not much gained by logging this. It's also a common source of false positive bug reports and bug reports with misleading symptoms in Flutter, such as flutter/flutter#78929 Instead of logging the error, simply suppress it, since it's not actionable by the user. CMAP Reference: https://docs.microsoft.com/en-us/typography/opentype/spec/cmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAP tables are a component of fonts which map character codes to glyph
indices used in the font. In cases where this is missing/corrupt for a font
that we attempt to load, there is not much gained by logging this. It's also
a common source of false positive bug reports, or misleading log messages.
Instead of logging the error, simply suppress it, since it's not
actionable by the user.
No new test since this simply suppresses a log message but does
not affect logic otherwise.
CMAP Reference:
https://docs.microsoft.com/en-us/typography/opentype/spec/cmap
Fixes flutter/flutter#78929
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.