This repository was archived by the owner on Feb 25, 2025. It is now read-only.
share font collections between spawn engines#23603
Merged
gaaclarke merged 2 commits intoflutter:masterfrom Jan 13, 2021
Merged
Conversation
f9a142c to
fceb51e
Compare
13 tasks
4987393 to
388c0a8
Compare
xster
approved these changes
Jan 13, 2021
chinmaygarde
approved these changes
Jan 13, 2021
388c0a8 to
e05b8b2
Compare
91bc5e9 to
8f576d0
Compare
Member
Author
|
Landing on red, the red is an infra failure timeout. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 13, 2021
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 20, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented sharing font collections between spawned engines.
Related Issues
fixes flutter/flutter#72024
Tests
I added the following tests:
EngineTest unit tests.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.