Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Flutter 1.22.0-12.3.pre engine cherrypicks#21466

Merged
christopherfujino merged 2 commits intoflutter:flutter-1.22-candidate.12from
christopherfujino:cherrypicks-flutter-1.22-candidate.12
Sep 28, 2020
Merged

Flutter 1.22.0-12.3.pre engine cherrypicks#21466
christopherfujino merged 2 commits intoflutter:flutter-1.22-candidate.12from
christopherfujino:cherrypicks-flutter-1.22-candidate.12

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 28, 2020 •
edited
Loading

Scheduled Cherrypicks

Known failures

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 28, 2020

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.22-candidate.12. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.22-candidate.12 to master September 28, 2020 19:20
@christopherfujino christopherfujino changed the base branch from master to flutter-1.22-candidate.12 September 28, 2020 19:20
blasten
blasten approved these changes Sep 28, 2020
View reviewed changes
Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @christopherfujino!

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 28, 2020

Thanks @christopherfujino!

No problem!

@christopherfujino christopherfujino marked this pull request as ready for review September 28, 2020 19:54
@auto-assign auto-assign bot requested a review from liyuqian September 28, 2020 19:55
@christopherfujino christopherfujino removed the request for review from liyuqian September 28, 2020 19:55
pcsosinski
pcsosinski approved these changes Sep 28, 2020
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 28, 2020

Everything is green except Mac/Windows Web Engine, which is failing on an infra failure. This is because try jobs are using the latest recipe, and not the branched recipe.

@christopherfujino christopherfujino merged commit 5babba6 into flutter:flutter-1.22-candidate.12 Sep 28, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.22-candidate.12 branch September 28, 2020 21:06
@blasten
Copy link

blasten commented Sep 28, 2020

@christopherfujino Please let me know once this commit has landed in the Flutter beta branch as we are waiting for that to release the webview plugin.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@blasten blasten blasten approved these changes

@pcsosinski pcsosinski pcsosinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes platform-android platform-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christopherfujino @blasten @pcsosinski @googlebot