This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle malloc edge-case in mock_engine#21102
Merged
cbracken merged 1 commit intoflutter:masterfrom Sep 11, 2020
cbracken:malloc-cleanup
Merged
Handle malloc edge-case in mock_engine#21102cbracken merged 1 commit intoflutter:masterfrom cbracken:malloc-cleanup
cbracken merged 1 commit intoflutter:masterfrom
cbracken:malloc-cleanup
Conversation
Make a single-param ctor explicit in order to prevent surprising implicit conversions. Add a check for zero message-size and don't malloc/memcpy the incoming message in those cases. Add braces where they were missing.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Member
Author
|
Extracted from #21091 so the commit history is a bit cleaner and we separate unrelated issues. |
cbracken
added
Work in progress (WIP)
Member
Author
|
Edit: looks like that's insufficient to appease the linter :/ |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a single-param ctor explicit in order to prevent surprising
implicit conversions.
Add a check for zero message-size and don't malloc/memcpy the incoming
message in those cases.
Add braces where they were missing.