This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Conversation
Contributor
Author
|
Actually - I have to double check this doesn't fail on x86 builds, that was the main blocker for rolling to clang head. |
Contributor
Author
|
Still failing on x86 builds, that has to get addrssed separately. |
chinmaygarde
approved these changes
Apr 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2020
This was referenced Apr 2, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 3, 2020
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 3, 2020
* 0b3f2d3 Always cache SkSL when using the Metal backend. (flutter/engine#17468) * ff62dec Roll to clang11, mark 4 (flutter/engine#17483) * 08ae3bb Remove JSON codec from C++ client wrapper (flutter/engine#17312) * 2e90965 Fix bad texture view config (flutter/engine#17486) * abc7293 [pipeline] Add trace event for lag between target and display times (flutter/engine#17384) * Updated bin/internal/fuchsia-linux.version
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
* "Reland Clang 11, roll buildroot to 1bc40a5, take 4 (flutter#17467)" (flutter#17482)" This reverts commit 8166a91. * format code * Roll buildroot to 3a27de1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @mkustermann
This relands #17482
Changes since last time:
llvm-arfrom the buildtools when building Android with clang. The NDK's ar utility is too old to be compatible anymore. This eliminates all the linker warnings we saw previously, and fixes building thegen_snapshottarget directly, which was failing on triple head bot.See also flutter/buildroot@3a27de1
I think this one will stick...