Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c"#17464

Merged
dnfield merged 1 commit intomasterfrom
revert-17457-clang
Apr 2, 2020
Merged

Revert "Reland Clang 11, Roll buildroot to 1bc40a5f916adb93d87e2a2230a0ec43db876c1c"#17464
dnfield merged 1 commit intomasterfrom
revert-17457-clang

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Apr 2, 2020

Reverts #17457

Broke ci. Still some more failures to fix. TBR @chinmaygarde

@dnfield dnfield merged commit 9eacd02 into master Apr 2, 2020
@dnfield dnfield deleted the revert-17457-clang branch April 2, 2020 00:51
@chinmaygarde
Copy link
Contributor

chinmaygarde commented Apr 2, 2020

lgtm. What are the failures now?

@dnfield
Copy link
Contributor Author

dnfield commented Apr 2, 2020

  1. Some more random symbols to whitelist for android_jit_release_x86 (easy fix)
  2. Some golden image tests in dart code that never got a chance to run last time around (add a couple more skips)
  3. Some dsymutil logic for building the ios framework - testing out a fix for that locally, hoping we can just use the newer dsymutil in the buildtools, but might have to start building ios_debug_sim with Xcode instead.

dnfield added a commit to dnfield/engine that referenced this pull request Apr 2, 2020
@dnfield
Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)" (flutter#…
1f75a0b 
…17464)

This reverts commit 9eacd02.
@dnfield dnfield mentioned this pull request Apr 2, 2020
Merged
dnfield added a commit that referenced this pull request Apr 2, 2020
@dnfield
Reland Clang 11, roll buildroot to 1bc40a5, take 3 (#17467)
39b7718 
* Reland Clang 11, Roll buildroot to 1bc40a5 (#17457)" (#17464)

This reverts commit 9eacd02.

* Skip more image tests, use newer dsymutil, add missing symbols
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 2, 2020
@engine-flutter-autoroll
9eacd02 Revert "Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#1…
09ca042 
…7457)" (flutter/engine#17464)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 2, 2020
Merged
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@dnfield @goderbauer
Revert "Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)" (f…
f14a6d8 
…lutter#17464)

This reverts commit a4026cc.
goderbauer pushed a commit to goderbauer/engine that referenced this pull request Apr 16, 2020
@dnfield @goderbauer
Reland Clang 11, roll buildroot to 1bc40a5, take 3 (flutter#17467)
add6498 
* Reland Clang 11, Roll buildroot to 1bc40a5 (flutter#17457)" (flutter#17464)

This reverts commit 9eacd02.

* Skip more image tests, use newer dsymutil, add missing symbols
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnfield @chinmaygarde @googlebot