Add compiler=js escape hatch to revert to dart2js compilation
#9406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
approved these changes
Aug 21, 2025
mdebbar
approved these changes
Aug 21, 2025
Contributor
mdebbar
left a comment
mdebbar
left a comment
There was a problem hiding this comment.
The change looks good to me.
As far as testing goes, ideally, you would load the app in an iframe with the ?compiler=js in the URL. Then you would poke into the HTML content of the iframe to make sure the attribute on the body is set to flt-renderer="canvaskit". But I'm not sure how to do a test like this in Dart/Flutter.
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #9398
Adds an "escape hatch" that allows a user to force the dart2js-compiled DevTools even when the dart2wasm-compiled DevTools fails to load (see for example #9118). This "escape hatch" is adding the query parameter
compiler=jsand forcing a reload.FYI @mdebbar - I'm trying to figure out a good way to test this (not sure if
integration_testcould be made to work, or ifpackage:webdriveris better, or...?) See #9405. Would love to hear your thoughts if you have any suggestions. Thanks!